Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Plain URL doesn't copy anything #1379

Open
OnkelTem opened this issue May 22, 2022 · 5 comments · May be fixed by #1445
Open

Copy Plain URL doesn't copy anything #1379

OnkelTem opened this issue May 22, 2022 · 5 comments · May be fixed by #1445
Labels

Comments

@OnkelTem
Copy link

Describe the bug
Copying "Plain URL" doesn't work.

To Reproduce
Steps to reproduce the behavior:

  1. Open https://carbon.now.sh/
  2. Select the "Plain URL" item from the copy menu:

image

  1. Open a new tab and paste the URL. It pastes just the site's root URL: https://carbon.now.sh/

Expected behavior
A link to the snippet would get copied.

Info (please complete the following information):

  • OS [e.g. macOS, Linux, Windows, iOS]: Linux
  • Browser [e.g. Chrome, Safari, Firefox]: Chrome 100
@OnkelTem OnkelTem added the bug label May 22, 2022
@mfix22
Copy link
Contributor

mfix22 commented Jun 5, 2022

Does your browser have access to the clipboard? This works great on all browsers I have access to.

@OnkelTem
Copy link
Author

OnkelTem commented Jun 5, 2022

Of course it has. It just doesn't copy anything the full URL. I can make a video.

UPDATE
https://www.youtube.com/watch?v=TFJFG5kp65o

@thevinitgupta
Copy link

@OnkelTem Have tried after logging in? Because I am seeing the same error until I login to my account.

@mfix22
Copy link
Contributor

mfix22 commented Nov 7, 2022

Thanks for the helpful reproduction video @OnkelTem! This should be an easy fix (I imagine you would be able to fix it yourself if you are interested).

@agilityhawk
Copy link

agilityhawk commented Jan 22, 2023

Hello. I was looking to pick this up and have been able to reproduce it on the prod site (thanks to the vid by @OnkelTem). However, in order to reproduce this locally and confirm my fix, I wanted to go through the flow and receive the API response that saves the snippet but am unable to locate the API/server-side code where this response is supposed to come from.

Since I was unable to find it in this code, I'm assuming that API and backend code for this is somewhere else?
@mfix22 - Could you provide further insights into this assumption please?

Thanks in advance!

P.S: Additionally, I was also hoping if we could add a local/placeholder .env file that just lists all the ENV variables that are consumed by this code, in case we wanted to set them up locally as well?

agilityhawk added a commit to agilityhawk/carbon that referenced this issue Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants