Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust exception logging for non-critical - or potentially spammy - situations #718

Open
klauer opened this issue Feb 10, 2021 · 1 comment
Labels
core Core (non-server/client/asyncio/etc) enhancement server pvproperty, PVGroup, and related

Comments

@klauer
Copy link
Member

klauer commented Feb 10, 2021

We can do better as to the user-friendliness of most of our log messages.

For example, if beacon broadcasts are failing, 10 lines per failed send with an exception traceback is excessive and not helpful to the end user.

Some thoughts:

  • Log level adjustment: debug has full traceback, such that -vv can be used to provide bug reports
  • warning can be used for user-friendly messages, sans-traceback
  • Truly critical errors - to the best of our knowledge - should probably still have error set with exc_info (or .exception())

(Half-baked thought at this point; will come back with further details when I have the time. Input/feedback very much welcome.)

@klauer klauer added enhancement core Core (non-server/client/asyncio/etc) server pvproperty, PVGroup, and related labels Feb 10, 2021
@danielballan
Copy link
Collaborator

For beacons in particular, if they are repeatedly failing to send it might makes sense to warn one (last) time and keep quiet, or warn only occasionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core (non-server/client/asyncio/etc) enhancement server pvproperty, PVGroup, and related
Projects
None yet
Development

No branches or pull requests

2 participants