Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xfail from the threading multi-client tests #420

Open
danielballan opened this issue Jan 19, 2019 · 2 comments · May be fixed by #434
Open

Remove xfail from the threading multi-client tests #420

danielballan opened this issue Jan 19, 2019 · 2 comments · May be fixed by #434

Comments

@danielballan
Copy link
Collaborator

We made some progress on the threading client test reliability in #346 (mostly fixes to the tests themselves, which weren't using the barriers quite right). But in the end we reinstated xfail in 887cb31 because the reliability was still poor on Travis.

I had to do some PR archaeology to remind myself of the present state and how we got here, and recording that is the purpose of this issue.
@danielballan danielballan linked a pull request Jan 28, 2019 that will close this issue
Open
@klauer
Copy link
Member

klauer commented Oct 2, 2020

Update: this is still marked as xfail as of v0.6.0.

@danielballan
Copy link
Collaborator Author

Note to Future Me or anyone else: I think the most fruitful place to push would be to resolve the dangling threads and sockets left after each test. We have instrumentation to report them already, but we haven’t yet addressed them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Un-xfail test_multithreaded_many_subscribe again. danielballan/caproto
2 participants
@danielballan @klauer