Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPView is missing rotateByAngle method #2982

Open
enquora opened this issue May 12, 2021 · 4 comments
Open

CPView is missing rotateByAngle method #2982

enquora opened this issue May 12, 2021 · 4 comments
Milestone

Comments

@enquora
Copy link
Contributor

enquora commented May 12, 2021

RotationTests.zip
Do we have an entirely distinct (from Objective-C) of accomplishing arbitrary rotation of a view or am I correct assuming it isn't currently possible without directly manipulating the underlying DOM?

The problem is deeper, as demonstrated by the attached reductions in each of Objective-C and Objective-J — which highlight a discrepancy in behaviour.

In Objective-C, setting a views' wantsLayer: automatically creates a layer, which one can directly apply an affine transformation to.

In Objective-J, it appears necessary to manually create the layer, then implement (void)drawInContext:(CGContextRef)ctx.
This suggests incomplete implementation of layer functionality compared to the reference implementation.

@cappbot cappbot added this to the Someday milestone May 12, 2021
@cappbot cappbot added the #new label May 12, 2021
@cappbot
Copy link

cappbot commented May 12, 2021

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@daboe01
Copy link
Contributor

daboe01 commented May 17, 2021

I do not see a universal and clean way to implement a tranformation matrix that works transparently with every view. This is because CPView can use different means of drawing, either canvas or DOM directly.
IMHO our abstraction is not deep enough to make rotateByAngle: work within CPView.

@daboe01
Copy link
Contributor

daboe01 commented Jul 8, 2021

-#new
+#needs-discussion

@cappbot
Copy link

cappbot commented Jul 8, 2021

Milestone: Someday. What's next? A reviewer should examine this issue.

@cappbot cappbot removed the #new label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants