Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaleUnitSquareToSize: does not appear to behave the same as native Objective-C version #2974

Open
enquora opened this issue Mar 17, 2021 · 6 comments

Comments

@enquora
Copy link
Contributor

enquora commented Mar 17, 2021

Reductions attached in both Objective-C and Objective-J.
Objective-J version behaves differently, as demonstrated by both Javascript console and crash.
Scaling Tests, Native and Cappuccino.zip

Note the manual test produces expected behaviour but uses a static superview.
This reduction places the scaled view in a resizable window and changes the unitSquare dynamically.

@cappbot cappbot added this to the Someday milestone Mar 17, 2021
@cappbot cappbot added the #new label Mar 17, 2021
@cappbot
Copy link

cappbot commented Mar 17, 2021

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@enquora enquora changed the title scaleUnitSquareToSize: does not appear to behave as native Objective-C version scaleUnitSquareToSize: does not appear to behave in same way native Objective-C version Mar 17, 2021
@daboe01
Copy link
Contributor

daboe01 commented Mar 26, 2021

-#new
+AppKit
+#needs-patch

@cappbot
Copy link

cappbot commented Mar 26, 2021

Milestone: Someday. Labels: #needs-patch, AppKit. What's next? This issue needs a volunteer to write and submit code to address it.

@enquora enquora changed the title scaleUnitSquareToSize: does not appear to behave in same way native Objective-C version scaleUnitSquareToSize: does not appear to behave the same as native Objective-C version Mar 26, 2021
@enquora
Copy link
Contributor Author

enquora commented Mar 26, 2021

@didierkorthoudt Would you mind trying both the native example and the Cappuccino one using your most current Aristo3 branch? It shouldn't take more than 5 minutes - resize the window and note the behaviour.

We appear to use CSS to manage scaleUnitSquareToSize:. I'm curious whether the same behaviour I'm seeing is still present with the theming changes you've made (so far) in Aristo3.

@enquora
Copy link
Contributor Author

enquora commented Mar 26, 2021

Note: the existing manual scaling test does result in expected behaviour, but seems to test only a subset of possible usages.

@daboe01
Copy link
Contributor

daboe01 commented Mar 28, 2021

@enquora we should add your reduction to the ManualTests. can you please make a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants