Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard-event handling is based on the deprecated charCode property of DOM Events #2882

Open
daboe01 opened this issue Jan 7, 2020 · 12 comments

Comments

@daboe01
Copy link
Contributor

daboe01 commented Jan 7, 2020

this needs to be addressed in the future as we are currently working around unexpected behaviors, i.e. for more recent FireFox versions.

@cappbot cappbot added this to the Someday milestone Jan 7, 2020
@cappbot cappbot added the #new label Jan 7, 2020
@cappbot
Copy link

cappbot commented Jan 7, 2020

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@enquora
Copy link
Contributor

enquora commented May 13, 2020

@daboe01 Can you change 'depreciated' to 'deprecated' in your issue title? It is the correct terminology and in this case may cause problems when searching issues.

@daboe01 daboe01 changed the title Keyboard-event handling is based on the depreciated charCode property of DOM Events Keyboard-event handling is based on the deprecated charCode property of DOM Events May 13, 2020
@enquora
Copy link
Contributor

enquora commented May 16, 2020

Keyboard navigation of CPOutlineView is non-functional in Firefox (haven't checked CPTableView yet). Perhaps this is the reason? Still functional in much earlier versions of Firefox and WebKit/Blink browsers.

@enquora
Copy link
Contributor

enquora commented May 16, 2020

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent indicates (suggesting the root of the problem wrt modern Firefox):

As of Firefox 65, the keypress event is no longer fired for non-printable keys (bug 968056), except for the Enter key, and the Shift + Enter and Ctrl + Enter key combinations (these were kept for cross-browser compatibility purposes).

The compatibility chart also indicates weak support for the modern API wrt Internet Explorer 9. Are we still concerned with support for any version of IE (Microsoft isn't)?

@daboe01
Copy link
Contributor Author

daboe01 commented May 16, 2020

@enquora your FF issues should be fixed in latest master. see #2874

@enquora
Copy link
Contributor

enquora commented May 16, 2020

@daboe01 The Firefox problem occurs using current master, but I'll re-check and refer comments to #2874 if appropriate.

@daboe01
Copy link
Contributor Author

daboe01 commented May 17, 2020

@enquora i just checked with FF76 on mac. here, keyboard navigation works with collectionview and tableview (not tested outlineview, though).

@enquora
Copy link
Contributor

enquora commented May 17, 2020

@daboe01 Confirmed that the minimal CPOutlineView manual test (from Cappuccino source) works as expected in all browsers. These problems are in several of our apps. There are no obvious handlers in the responder chains which might account for this - it will be necessary to reduce the app to isolate the behaviour and determine if it is caused by application code or a non-obvious interaction within Cappuccino itself.

@daboe01
Copy link
Contributor Author

daboe01 commented May 17, 2020

@enquora just guessing, could it be that the firstresponder state of you outlineview is lost somehow?

@daboe01
Copy link
Contributor Author

daboe01 commented May 31, 2020

-#new
+AppKit

@daboe01
Copy link
Contributor Author

daboe01 commented May 31, 2020

+#acknowledged

@cappbot
Copy link

cappbot commented May 31, 2020

Milestone: Someday. Labels: #acknowledged, AppKit. What's next? A reviewer should examine this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants