Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to update Categorical for TimeIt Tests #806

Open
JGSweets opened this issue May 3, 2023 · 0 comments
Open

Need to update Categorical for TimeIt Tests #806

JGSweets opened this issue May 3, 2023 · 0 comments
Assignees
@JGSweets @taylorfturner @micdavis @ksneab7
Labels
contribution_day good_first_issue Label for a more simple / introductory issue Help Wanted Extra attention is needed Medium Priority Significant improvement or bug / feature reducing overall performance Refactor Code that is being modified to improve the library

Comments

@JGSweets
Copy link
Collaborator

JGSweets commented May 3, 2023 •
edited

Currently, the tests pop the the times dict as opposed to validating the times are properly generated by mocking the timeit functionality.

Location:
https://github.com/capitalone/DataProfiler/blob/56e34f837bb0667d69392fd06caf2145724452f4/dataprofiler/tests/profilers/test_categorical_column_profile.py

We could utilize this similar functionality:

DataProfiler/dataprofiler/tests/profilers/test_profile_builder.py

Line 106 in f206af2

with test_utils.mock_timeit():

@JGSweets JGSweets added Help Wanted Extra attention is needed Medium Priority Significant improvement or bug / feature reducing overall performance Refactor Code that is being modified to improve the library good_first_issue Label for a more simple / introductory issue labels May 3, 2023
@JGSweets JGSweets mentioned this issue May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JGSweets JGSweets

@taylorfturner taylorfturner

@micdavis micdavis

@ksneab7 ksneab7

Labels
contribution_day good_first_issue Label for a more simple / introductory issue Help Wanted Extra attention is needed Medium Priority Significant improvement or bug / feature reducing overall performance Refactor Code that is being modified to improve the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JGSweets @taylorfturner @micdavis @ksneab7