[MRG] Add fine-tune CV model API #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change auto layer typing hint * Add example for `Structure` fields
* Remove uncleared private attribute * Add parse from pytorch nn module function * Simplify type hint for `ModelLayer`
univerone
previously approved these changes
Jan 29, 2021
* Update requirement packages to fix torchvision version * Change name: model_structure_vo.py -> model_structure.py * Add todo to simplify `modelci.hub.manager.register_model` logic
YuanmingLeee
changed the title
|
lgtm. You can creat a exp/ dir and put some code into it to speed up your progress. We will not review code in it. |
HuaizhengZhang
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done to verify that this works as intended?
First, make sure you have installed the correct experimental environment according to
CONTRIBUTE.md. You have also installed themodelcipip package, to enable the CLI tools. You have also started the ModelCI service by:Then register a
ResNet50, PyTorchmodel into the ModelDB.Next, start the frontend. (Kill it first if you have started it before)
Now, go the the 0.0.0.0:8000/docs, try the API
Click
Try it out, find the model ID of the PyTorch model*, and click execute as follows:Why is this the best possible solution? Were any other approaches considered?
To be discussed.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
A new feature, no breaking changes to the existing system.
Does this change require updates to documentation?
Yes.
Before submitting this PR, please make sure you have:
python -m pytest tests/and confirmed all checks still pass.