-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing mcfly on Ubuntu 24.04 doesn't bind CTRL+R and "mcfly search" throws error #409
Comments
Did you also add it to your ~/.bashrc, ~/.zshrc, or ~/.config/fish/config.fish file? |
Yes. It is already there. I merely upgraded from 22.04 to 24.04 and this error started showing up. If I set |
This means that mcfly's setup shell code isn't being executed, I suspect. If you're in a new shell and getting this error, and then you run the appropriate one of these, does it work? Bash: Zsh: Fish: |
I started a new shell. Executed the command.
Still same error. CTRL+R is not binded.
|
I'm not sure what's going on. Does it work in Zsh? |
I tried it in Bash shell and it works in Bash. Switched to Bash shell, executed : eval "$(mcfly init bash)" CTRL+R is binded properly and no error is thrown. |
This could be related to #333 ? see also #404 |
I am using kernel |
Something similar here:
CTRL+r works as always, but, once I hit enter, there is fraction of a second of a text being shown, and nothing happens. Grabacion.de.pantalla.desde.2024-05-30.14-26-43.mp4 |
I got the same trouble. deskmini with AMD Ryzen 2200G, 16G > uname -a
Linux deskmini 6.8.0-31-generic #31-Ubuntu SMP PREEMPT_DYNAMIC Sat Apr 20 00:40:06 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
> mcfly -V
mcfly 0.8.6 CTRL-R works and MCFLY_HISTORY is correct. When I try CTRL-R as a root, it works. I checked the temp files and I think the permission for them are set correctly. # echo $MCFLY_HISTORY
/tmp/mcfly.SBmH3qQ5
> echo $MCFLY_HISTORY
/tmp/mcfly.FxOY7CBm
> ls -l /tmp
-rw------- 1 root root 1872 6月 1 09:49 mcfly.SBmH3qQ5
-rw------- 1 myusr myusr 1251 6月 1 09:55 mcfly.FxOY7CBm |
Should hopefully be fixed by #416 and https://github.com/cantino/mcfly/releases/tag/v0.9.0. |
Thank you. |
I did the same. I followed the cargo installation steps. It works now. |
I have one feature suggestion. Harmful and common destructive commands should be filtered out. So there should be prompting just like cloud companies have when we deleter a bucket or object e.g. type 'DELETE'. e.g. "rm -rf *" |
sounds like a new feat req issue to me 😉 |
I believe this is fixed! Please re-open if not. @dineshdharme, feel free to make a feature request or PR for blacklisting rm -rf commands, I think that's a good idea (if hard to do comprehensively). |
I installed mcfly. First, mcfly didn't bind the CTRL+R.
So I typed out "mcfly search" and following error was thrown.
The text was updated successfully, but these errors were encountered: