Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in mcfly.fish #406

Closed
manfredlotz opened this issue Apr 9, 2024 · 5 comments
Closed

Bug in mcfly.fish #406

manfredlotz opened this issue Apr 9, 2024 · 5 comments

Comments

@manfredlotz
Copy link
Contributor

I am using mcfly 0.8.4

mcfly.fish here in the repository and so mcfly init fish output is buggy.

here

...
 function __mcfly_add_command -d 'Add run commands to McFly database' -e fish_postexec
    # Check for the private mode
    test -n "$fish_private_mode"; and return
    # Retain return code of last command before we lose it
    set -l last_status $status
...

the value of last_status is always 1. Reason is that set -l last_status $status is not the first statemen in function __mcfly_add_command

@cantino
Copy link
Owner

cantino commented Apr 25, 2024

I don't use fish but I'm open to a PR to fix this.

@manfredlotz
Copy link
Contributor Author

Ok, will do. Plan for coming weekend when I will have more time doing things.

@4t8dd
Copy link

4t8dd commented May 16, 2024

just swapping the first two line will fix this issue.

@manfredlotz
Copy link
Contributor Author

@4t8dd Yes, that is what I mentioned above and what I did.

@cantino
Copy link
Owner

cantino commented May 26, 2024

Fixed in #414

@cantino cantino closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants