Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry options to Container methods #1144

Open
tonyandrewmeyer opened this issue Mar 7, 2024 · 1 comment
Open

Add retry options to Container methods #1144

tonyandrewmeyer opened this issue Mar 7, 2024 · 1 comment
Labels
feature New feature or request needs design needs more thought or spec

Comments

@tonyandrewmeyer
Copy link
Contributor

If there's a temporary (very short-lived) issue communicating with Pebble, then we generally recommend that charms retry a small number of times (with appropriate pauses between attempts) rather than defer(), return, or error out.

Rather than having every charm implement a retry mechanism, we could add this as an option to the various Container methods (but not the underlying Pebble class), so that we handle this transparently for users.

We'd need to consider when retrying is/is not appropriate, as well as what the retry pattern should be.

This Discourse post has more details on the motivation.

@tonyandrewmeyer tonyandrewmeyer added feature New feature or request needs design needs more thought or spec labels Mar 7, 2024
@benhoyt
Copy link
Collaborator

benhoyt commented May 17, 2024

Per Madrid discussion, this still seems like a reasonable idea, but needs a bit more charm research and a proof of concept to validate it. And do we want to do it on every method, or just the read/GET/non-mutating ones?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request needs design needs more thought or spec
Projects
None yet
Development

No branches or pull requests

2 participants