Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DESIGN] Extract logic for certificate renewal to its own separate method #28

Open
Mehdi-Bendriss opened this issue May 6, 2024 · 2 comments

Comments

@Mehdi-Bendriss
Copy link
Contributor

Context of issue here #22 (comment)

Copy link

github-actions bot commented May 6, 2024

@juditnovak
Copy link
Contributor

Adding the original comment for clarity:

We should consider extracting the logic of expiring into some method renew_certificates or similar and call it from here as well as from _on_certificate_expiring.
The reason being that this is now fine, but only because we are not making use of the event: CertificateExpiringEvent that's normally passed as an argument of _on_certificate_expiring.

We are not using the event by policy . It's not a co-incidence.

The charm was doing this before the particular modification that triggered this thread (see _set_tls_private_key()).

My question is: are there any risks implied by the current policy?

@juditnovak juditnovak changed the title Extract logic for certificate renewal to its own separate method [DESIGN] Extract logic for certificate renewal to its own separate method May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants