Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize the constants in the charm #90

Open
wood-push-melon opened this issue Jul 4, 2023 · 1 comment
Open

Organize the constants in the charm #90

wood-push-melon opened this issue Jul 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wood-push-melon
Copy link
Contributor

Enhancement Proposal

Context

It would be better to re-organize the constants being used in the charm.

  • The constants are scattered around in different modules and tests. But some of them are duplicated.
  • The constants are not well organized visually and logically. They are either declared as variables in the global scope or as the charm's attributes. Besides that, some of them should not be the charm's attributes IMHO.
  • There are some literals flying around in the charm which could also be managed.

Proposal

It is better to isolate the constants somewhere else (e.g. in an individual module) instead of piling them in an unorganized way. Highly correlated constants could be grouped together in data structures or classes to make sense semantically and logically.

@wood-push-melon wood-push-melon added the enhancement New feature or request label Jul 4, 2023
@shipperizer shipperizer added enhancement New feature or request and removed enhancement New feature or request labels May 21, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/IAM-882.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants