Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mounts shared pvc to shared folder. #120

Merged
merged 1 commit into from
May 6, 2024
Merged

Mounts shared pvc to shared folder. #120

merged 1 commit into from
May 6, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented May 3, 2024 •
edited

partialy resolves: #102
this resolution was agreed to take for version 1.

based on the comment we will mount pvc to shared instead of the home folder.

@misohu misohu requested a review from a team as a code owner May 3, 2024 11:39
@NohaIhab
Copy link
Contributor

NohaIhab commented May 3, 2024

thanks @misohu !
As a first iteration this is ok, but I don't believe this PR resolves #102 entirely.
We still need to keep track of the piece to have a separate PVC for each notebook, so I suggest before you merge, either:

  • change the description and keep the issue open
  • or file a new issue for the separate PVCs.

@misohu misohu merged commit 36058cc into main May 6, 2024
9 checks passed
@misohu misohu deleted the KF-5608-mount-pvc-to-shared branch May 6, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate notebooks appear to share state
2 participants
@misohu @NohaIhab