Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce chars in [a-z0-9/-] for id fields (jobs, templates, categories) #1188

Open
pieqq opened this issue Apr 16, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@pieqq
Copy link
Collaborator

pieqq commented Apr 16, 2024

Bug Description

Currently, Checkbox accepts almost any characters in the id and template-id fields of jobs, templates, test plans and categories. However, the documentation mentions

id:

(mandatory) - A name for the job. Should be unique, an error will be generated if there are duplicates. Should contain characters in [a-z0-9/-].

A potential problem is that if a unit id uses a character used in a regular expression, that unit id will look like a regular expression when including/excluding it in a test plan. This can lead to many issues (such as units being ignored).

Validation rules should be in place so that ./manage.py validate should return errors if a unit id/template-id includes any characters other than [a-z0-9/-].

@pieqq pieqq added the bug Something isn't working label Apr 16, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1402.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant