Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting an Action When Resume Incompleted sessions Got Keyerror #1186

Open
LiaoU3 opened this issue Apr 16, 2024 · 1 comment
Open

Selecting an Action When Resume Incompleted sessions Got Keyerror #1186

LiaoU3 opened this issue Apr 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@LiaoU3
Copy link
Contributor

LiaoU3 commented Apr 16, 2024

Bug Description

When resuming a session, we will be asked to select an action in page What to do with the last job? such as Add comment, Resume and skip the job, etc. Then, if we move selection out of the boundry, we will get key error.

To Reproduce

  1. Create an incompleted session by interrupting any testplan.
  2. Resume it.
  3. Try to press up or down several time to reach the boundary

Environment

  • Checkbox Type: snap
  • Checkbox Version: 4.0.0-dev226

Relevant log output

u@u:~$ checkbox-iiotg-classic.checkbox-cli 
$PROVIDERPATH is defined, so following provider sources are ignored ['/snap/checkbox-iiotg-classic/81/providers/checkbox-provider-intliotg', '/home/u/.local/share/plainbox-providers-1', '/var/tmp/checkbox-providers-develop'] 
Using sideloaded provider: checkbox-provider-intliotg, version 0.2 from /var/tmp/checkbox-providers
WARNING:plainbox.secure.providers.v1:Skipped file: /snap/checkbox22/current/providers/checkbox-provider-base/units/stress/suspend_cycles_reboot.md
Failed to disable unit: Unit file plainbox-autostart.service does not exist.
rm: cannot remove '/etc/systemd/system/plainbox-autostart.service': No such file or directory
WARNING:plainbox.providers.__init__:Using sideloaded provider: checkbox-provider-intliotg, version 0.2 from /var/tmp/checkbox-providers
Preparing...
Traceback (most recent call last):
  File "/snap/checkbox22/current/lib/python3.10/site-packages/checkbox_ng/launcher/subcommands.py", line 262, in invoked
    self._start_new_session()
  File "/snap/checkbox22/current/lib/python3.10/site-packages/checkbox_ng/launcher/subcommands.py", line 642, in _start_new_session
    tp_id = self._interactively_pick_test_plan()
  File "/snap/checkbox22/current/lib/python3.10/site-packages/checkbox_ng/launcher/subcommands.py", line 683, in _interactively_pick_test_plan
    ).run()
  File "/snap/checkbox22/current/lib/python3.10/site-packages/checkbox_ng/urwid_ui.py", line 816, in run
    raise ResumeInstead()
checkbox_ng.urwid_ui.ResumeInstead

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/snap/checkbox22/current/bin/checkbox-cli", line 8, in <module>
    sys.exit(main())
  File "/snap/checkbox22/current/lib/python3.10/site-packages/checkbox_ng/launcher/checkbox_cli.py", line 165, in main
    return subcmd.invoked(ctx)
  File "/snap/checkbox22/current/lib/python3.10/site-packages/checkbox_ng/launcher/subcommands.py", line 267, in invoked
    something_got_chosen = self._manually_resume_session(
  File "/snap/checkbox22/current/lib/python3.10/site-packages/checkbox_ng/launcher/subcommands.py", line 469, in _manually_resume_session
    self._resume_session_via_resume_params(resume_params)
  File "/snap/checkbox22/current/lib/python3.10/site-packages/checkbox_ng/launcher/subcommands.py", line 497, in _resume_session_via_resume_params
    outcome = {
KeyError: None

Additional context

No response
Screenshot from 2024-04-17 08-52-29

@LiaoU3 LiaoU3 added the bug Something isn't working label Apr 16, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1401.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant