Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stressors disabled by stress-ng should be skipped, as they return 1 and mark the jobs as failed instead #1173

Open
pieqq opened this issue Apr 11, 2024 · 3 comments
Open

stressors disabled by stress-ng should be skipped, as they return 1 and mark the jobs as failed instead #1173

pieqq opened this issue Apr 11, 2024 · 3 comments
Labels
enhancement New feature or request stress-ng

Comments

@pieqq
Copy link
Collaborator

pieqq commented Apr 11, 2024

Enhancement Proposal

On some devices, some stress-ng related tests are marked as failed. When reviewing the results, the output looks like this:

stress-ng: debug: [8619] invoked with 'stress-ng --bad-ioctl 0 --timeout 30 --skip-silent --verbose' by user 1000
stress-ng: debug: [8619] stress-ng 0.15.09 gefc98a49f14e
stress-ng: debug: [8619] system: Linux ubuntu 5.15.0-1045-intel-iotg #51-Ubuntu SMP Wed Nov 15 11:42:05 UTC 2023 x86_64, glibc 2.35
stress-ng: debug: [8619] RAM total: 31.2G, RAM free: 29.7G, swap free: 0.0
stress-ng: debug: [8619] temporary file path: '/var/tmp', filesystem type: ext2 (471348040 blocks available)
stress-ng: debug: [8619] 8 processors online, 8 processors configured
stress-ng: info:  [8619] disabled 'bad-ioctl' as it may hang or reboot the machine (enable it with the --pathological option)
stress-ng: info:  [8619] setting to a 30 second run per stressor
stress-ng: error: [8619] No stress workers invoked
EXIT_CODE=1

It looks like stress-ng decides to disable this stressor when it is executed. Instead of running this (and getting an exit code of 1 sent by strss-ng), the stress-ng-stressors resource job should be modified so that each stressor have a status field set to enabled or disabled, so that the template job can ignore stressors that have the disabled status.

Currently, stress-ng-stressors job simply returns the names of each stressor:

stressor: access

stressor: af-alg

stressor: affinity

(...)

It should, instead, return something like:

stressor: access
status: enabled

stressor: af-alg
status: disabled

stressor: affinity
status: enabled
@pieqq pieqq added the enhancement New feature or request label Apr 11, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1383.

This message was autogenerated

@pieqq pieqq mentioned this issue Apr 11, 2024
Open
@LiaoU3
Copy link
Contributor

LiaoU3 commented Apr 11, 2024

Me and @stanley31huang found that the latest verstion of stress-ng fixes this issue which means that return code is 0.

(base) vincent@vincent-XPS-9320:~$ stress-ng --version
stress-ng, version 0.16.05 (gcc 13.2.0, x86_64 Linux 6.5.0-27-generic) 💻🔥
(base) vincent@vincent-XPS-9320:~$ stress-ng --bad-ioctl 0 --timeout 30 --skip-silent --verbose
stress-ng: debug: [31713] invoked with 'stress-ng --bad-ioctl 0 --timeout 30 --skip-silent --verbose' by user 1000 'vincent'
stress-ng: debug: [31713] stress-ng 0.16.05
stress-ng: debug: [31713] system: Linux vincent-XPS-9320 6.5.0-27-generic #28-Ubuntu SMP PREEMPT_DYNAMIC Thu Mar  7 18:21:00 UTC 2024 x86_64, gcc 13.2.0, glibc 2.38
stress-ng: debug: [31713] RAM total: 15.2G, RAM free: 1.6G, swap free: 1.9G
stress-ng: debug: [31713] temporary file path: '/home/vincent', filesystem type: ext2 (93904806 blocks available)
stress-ng: debug: [31713] CPUs have 5 idle states: C10 C1E C6 C8 POLL
stress-ng: debug: [31713] 16 processors online, 16 processors configured
stress-ng: info:  [31713] disabled 'bad-ioctl' as it may hang or reboot the machine (enable it with the --pathological option)
stress-ng: info:  [31713] setting to a 30 secs run per stressor
stress-ng: debug: [31713] CPU data cache: L1: 48K, L2: 1280K, L3: 12288K
stress-ng: debug: [31713] cache allocate: shared cache buffer size: 12288K
stress-ng: info:  [31713] dispatching hogs:
stress-ng: debug: [31713] starting stressors
stress-ng: debug: [31713] 0 stressors started
stress-ng: warn:  [31713] metrics-check: all bogo-op counters are zero, data may be incorrect
stress-ng: debug: [31713] metrics-check: all stressor metrics validated and sane
stress-ng: info:  [31713] skipped: 16: bad-ioctl (16)
stress-ng: info:  [31713] passed: 0
stress-ng: info:  [31713] failed: 0
stress-ng: info:  [31713] metrics untrustworthy: 0
stress-ng: info:  [31713] successful run completed in 0.00 secs
(base) vincent@vincent-XPS-9320:~$ echo $?
0
(base) vincent@vincent-XPS-9320:~$ stress-ng --bind-mount 0 --timeout 30 --skip-silent --verbose
stress-ng: debug: [31714] invoked with 'stress-ng --bind-mount 0 --timeout 30 --skip-silent --verbose' by user 1000 'vincent'
stress-ng: debug: [31714] stress-ng 0.16.05
stress-ng: debug: [31714] system: Linux vincent-XPS-9320 6.5.0-27-generic #28-Ubuntu SMP PREEMPT_DYNAMIC Thu Mar  7 18:21:00 UTC 2024 x86_64, gcc 13.2.0, glibc 2.38
stress-ng: debug: [31714] RAM total: 15.2G, RAM free: 1.6G, swap free: 1.9G
stress-ng: debug: [31714] temporary file path: '/home/vincent', filesystem type: ext2 (93904802 blocks available)
stress-ng: debug: [31714] CPUs have 5 idle states: C10 C1E C6 C8 POLL
stress-ng: debug: [31714] 16 processors online, 16 processors configured
stress-ng: info:  [31714] disabled 'bind-mount' as it may hang or reboot the machine (enable it with the --pathological option)
stress-ng: info:  [31714] setting to a 30 secs run per stressor
stress-ng: debug: [31714] CPU data cache: L1: 48K, L2: 1280K, L3: 12288K
stress-ng: debug: [31714] cache allocate: shared cache buffer size: 12288K
stress-ng: info:  [31714] dispatching hogs:
stress-ng: debug: [31714] starting stressors
stress-ng: debug: [31714] 0 stressors started
stress-ng: warn:  [31714] metrics-check: all bogo-op counters are zero, data may be incorrect
stress-ng: debug: [31714] metrics-check: all stressor metrics validated and sane
stress-ng: info:  [31714] skipped: 16: bind-mount (16)
stress-ng: info:  [31714] passed: 0
stress-ng: info:  [31714] failed: 0
stress-ng: info:  [31714] metrics untrustworthy: 0
stress-ng: info:  [31714] successful run completed in 0.00 secs
(base) vincent@vincent-XPS-9320:~$ echo $?
0
(base) vincent@vincent-XPS-9320:~$ stress-ng --mlockmany 0 --timeout 30 --skip-silent --verbose
stress-ng: debug: [31730] invoked with 'stress-ng --mlockmany 0 --timeout 30 --skip-silent --verbose' by user 1000 'vincent'
stress-ng: debug: [31730] stress-ng 0.16.05
stress-ng: debug: [31730] system: Linux vincent-XPS-9320 6.5.0-27-generic #28-Ubuntu SMP PREEMPT_DYNAMIC Thu Mar  7 18:21:00 UTC 2024 x86_64, gcc 13.2.0, glibc 2.38
stress-ng: debug: [31730] RAM total: 15.2G, RAM free: 1.6G, swap free: 1.9G
stress-ng: debug: [31730] temporary file path: '/home/vincent', filesystem type: ext2 (93904795 blocks available)
stress-ng: debug: [31730] CPUs have 5 idle states: C10 C1E C6 C8 POLL
stress-ng: debug: [31730] 16 processors online, 16 processors configured
stress-ng: info:  [31730] disabled 'mlockmany' as it may hang or reboot the machine (enable it with the --pathological option)
stress-ng: info:  [31730] setting to a 30 secs run per stressor
stress-ng: debug: [31730] CPU data cache: L1: 48K, L2: 1280K, L3: 12288K
stress-ng: debug: [31730] cache allocate: shared cache buffer size: 12288K
stress-ng: info:  [31730] dispatching hogs:
stress-ng: debug: [31730] starting stressors
stress-ng: debug: [31730] 0 stressors started
stress-ng: warn:  [31730] metrics-check: all bogo-op counters are zero, data may be incorrect
stress-ng: debug: [31730] metrics-check: all stressor metrics validated and sane
stress-ng: info:  [31730] skipped: 16: mlockmany (16)
stress-ng: info:  [31730] passed: 0
stress-ng: info:  [31730] failed: 0
stress-ng: info:  [31730] metrics untrustworthy: 0
stress-ng: info:  [31730] successful run completed in 0.00 secs
(base) vincent@vincent-XPS-9320:~$ echo $?
0
(base) vincent@vincent-XPS-9320:~$ stress-ng --oom-pipe 0 --timeout 30 --skip-silent --verbose
stress-ng: debug: [31731] invoked with 'stress-ng --oom-pipe 0 --timeout 30 --skip-silent --verbose' by user 1000 'vincent'
stress-ng: debug: [31731] stress-ng 0.16.05
stress-ng: debug: [31731] system: Linux vincent-XPS-9320 6.5.0-27-generic #28-Ubuntu SMP PREEMPT_DYNAMIC Thu Mar  7 18:21:00 UTC 2024 x86_64, gcc 13.2.0, glibc 2.38
stress-ng: debug: [31731] RAM total: 15.2G, RAM free: 1.5G, swap free: 1.9G
stress-ng: debug: [31731] temporary file path: '/home/vincent', filesystem type: ext2 (93904794 blocks available)
stress-ng: debug: [31731] CPUs have 5 idle states: C10 C1E C6 C8 POLL
stress-ng: debug: [31731] 16 processors online, 16 processors configured
stress-ng: info:  [31731] disabled 'oom-pipe' as it may hang or reboot the machine (enable it with the --pathological option)
stress-ng: info:  [31731] setting to a 30 secs run per stressor
stress-ng: debug: [31731] CPU data cache: L1: 48K, L2: 1280K, L3: 12288K
stress-ng: debug: [31731] cache allocate: shared cache buffer size: 12288K
stress-ng: info:  [31731] dispatching hogs:
stress-ng: debug: [31731] starting stressors
stress-ng: debug: [31731] 0 stressors started
stress-ng: warn:  [31731] metrics-check: all bogo-op counters are zero, data may be incorrect
stress-ng: debug: [31731] metrics-check: all stressor metrics validated and sane
stress-ng: info:  [31731] skipped: 16: oom-pipe (16)
stress-ng: info:  [31731] passed: 0
stress-ng: info:  [31731] failed: 0
stress-ng: info:  [31731] metrics untrustworthy: 0
stress-ng: info:  [31731] successful run completed in 0.00 secs
(base) vincent@vincent-XPS-9320:~$ echo $?
0
(base) vincent@vincent-XPS-9320:~$ stress-ng --sysinval 0 --timeout 30 --skip-silent --verbose
stress-ng: debug: [31742] invoked with 'stress-ng --sysinval 0 --timeout 30 --skip-silent --verbose' by user 1000 'vincent'
stress-ng: debug: [31742] stress-ng 0.16.05
stress-ng: debug: [31742] system: Linux vincent-XPS-9320 6.5.0-27-generic #28-Ubuntu SMP PREEMPT_DYNAMIC Thu Mar  7 18:21:00 UTC 2024 x86_64, gcc 13.2.0, glibc 2.38
stress-ng: debug: [31742] RAM total: 15.2G, RAM free: 1.6G, swap free: 1.9G
stress-ng: debug: [31742] temporary file path: '/home/vincent', filesystem type: ext2 (93904791 blocks available)
stress-ng: debug: [31742] CPUs have 5 idle states: C10 C1E C6 C8 POLL
stress-ng: debug: [31742] 16 processors online, 16 processors configured
stress-ng: info:  [31742] disabled 'sysinval' as it may hang or reboot the machine (enable it with the --pathological option)
stress-ng: info:  [31742] setting to a 30 secs run per stressor
stress-ng: debug: [31742] CPU data cache: L1: 48K, L2: 1280K, L3: 12288K
stress-ng: debug: [31742] cache allocate: shared cache buffer size: 12288K
stress-ng: info:  [31742] dispatching hogs:
stress-ng: debug: [31742] starting stressors
stress-ng: debug: [31742] 0 stressors started
stress-ng: warn:  [31742] metrics-check: all bogo-op counters are zero, data may be incorrect
stress-ng: debug: [31742] metrics-check: all stressor metrics validated and sane
stress-ng: info:  [31742] skipped: 16: sysinval (16)
stress-ng: info:  [31742] passed: 0
stress-ng: info:  [31742] failed: 0
stress-ng: info:  [31742] metrics untrustworthy: 0
stress-ng: info:  [31742] successful run completed in 0.00 secs
(base) vincent@vincent-XPS-9320:~$ echo $?
0
(base) vincent@vincent-XPS-9320:~$ stress-ng --watchdog 0 --timeout 30 --skip-silent --verbose
stress-ng: debug: [31761] invoked with 'stress-ng --watchdog 0 --timeout 30 --skip-silent --verbose' by user 1000 'vincent'
stress-ng: debug: [31761] stress-ng 0.16.05
stress-ng: debug: [31761] system: Linux vincent-XPS-9320 6.5.0-27-generic #28-Ubuntu SMP PREEMPT_DYNAMIC Thu Mar  7 18:21:00 UTC 2024 x86_64, gcc 13.2.0, glibc 2.38
stress-ng: debug: [31761] RAM total: 15.2G, RAM free: 1.6G, swap free: 1.9G
stress-ng: debug: [31761] temporary file path: '/home/vincent', filesystem type: ext2 (93904783 blocks available)
stress-ng: debug: [31761] CPUs have 5 idle states: C10 C1E C6 C8 POLL
stress-ng: debug: [31761] 16 processors online, 16 processors configured
stress-ng: info:  [31761] disabled 'watchdog' as it may hang or reboot the machine (enable it with the --pathological option)
stress-ng: info:  [31761] setting to a 30 secs run per stressor
stress-ng: debug: [31761] CPU data cache: L1: 48K, L2: 1280K, L3: 12288K
stress-ng: debug: [31761] cache allocate: shared cache buffer size: 12288K
stress-ng: info:  [31761] dispatching hogs:
stress-ng: debug: [31761] starting stressors
stress-ng: debug: [31761] 0 stressors started
stress-ng: warn:  [31761] metrics-check: all bogo-op counters are zero, data may be incorrect
stress-ng: debug: [31761] metrics-check: all stressor metrics validated and sane
stress-ng: info:  [31761] skipped: 16: watchdog (16)
stress-ng: info:  [31761] passed: 0
stress-ng: info:  [31761] failed: 0
stress-ng: info:  [31761] metrics untrustworthy: 0
stress-ng: info:  [31761] successful run completed in 0.00 secs
(base) vincent@vincent-XPS-9320:~$ echo $?
0
``

@LiaoU3
Copy link
Contributor

LiaoU3 commented Apr 12, 2024

I built checkbox snap with stress-ng v0.17.07. All jobs are passed now (except something are crashed).
ARM:
https://certification.canonical.com/hardware/202312-33205/submission/363895/
https://certification.canonical.com/hardware/202312-33205/submission/363914/
X86:
https://certification.canonical.com/hardware/202311-32337/submission/363913/
https://certification.canonical.com/hardware/202311-32337/submission/363938/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request stress-ng
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pieqq @LiaoU3