Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[check-libraries] Detect library changes on PR without LIBPATCH bump #90

Open
taurus-forever opened this issue Mar 9, 2023 · 1 comment
Labels

Comments

@taurus-forever
Copy link
Contributor

Enhancement Proposal

Hi,

We are running check-libraries on PRs to make sure our charms are using the latest shared libraries.
The approach with green/red labels works perfectly: example.

What is missing is a human protection to inform author about forgotten LIBPATCH bump on the shared library change: example.

What about to set red label: Libraries: bump LIBPATCH if author changes shared library and forget to bump it?
At the moment the action simply prints notice and sets green label Libraries: OK:

Library charms.mongodb.v0.helpers has local changes, cannot be updated.
Library charms.mongodb.v0.mongodb_backups has local changes, cannot be updated.
Library charms.mongodb.v0.mongodb_vm_legacy_provider has local changes, cannot be updated.

We have tried to use option fail-build, but it didn't fail on locally changed library.
Is it a broken option or it was designed for something else? Tnx!

@taurus-forever
Copy link
Contributor Author

taurus-forever commented Mar 10, 2023

Just for the history, the option fail-build fails the build if updates are available on charmhub, e.g.:

Library charms.operator_libs_linux.v1.snap updated to version 1.8.
Library charms.operator_libs_linux.v1.systemd updated to version 1.2.

The option fail-build does not react on locally modified libraries at all. It is not well documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant