Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-libraries] silently keeps library non-published if LIBPATCH is too high (it needs to be consecutive) #86

Open
taurus-forever opened this issue Feb 27, 2023 · 0 comments
Labels
Status: Triage Type: Bug Something isn't working

Comments

@taurus-forever
Copy link
Contributor

Bug Description

HI,

The release-libraries silently keeps library non-published if LIBPATCH is too high due to human mistake
(e.g. the latest published LIBPATCH is 3 and the currently committed is 5):

> charmcraft publish-lib charms.mongodb.v0.mongodb_tls
Library charms.mongodb.v0.mongodb_tls has a wrong LIBPATCH number, 
it's too high and needs to be consecutive, Charmhub highest version is 0.3.                                                                                                                                    

> echo $?
0

Charmhub enforces LIBPATCH needs to be consecutive. Unfortunately exit code there is zero, so it is silently missing.

To Reproduce

  1. bump LIBPATCH on 2+ versions to the current
  2. try to publish new library

Environment

charmhub 2.2.0
charming-actions 2.2.2

Relevant log output

> charmcraft publish-lib charms.mongodb.v0.mongodb_tls
Library charms.mongodb.v0.mongodb_tls has a wrong LIBPATCH number, it's too high and needs to be consecutive, Charmhub highest version is 0.3.                                                                                                                                    

> echo $?
0

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant