Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for specific bundle paths #69

Open
jardon opened this issue Oct 13, 2022 · 0 comments
Open

Allow for specific bundle paths #69

jardon opened this issue Oct 13, 2022 · 0 comments
Labels

Comments

@jardon
Copy link

jardon commented Oct 13, 2022

Enhancement Proposal

Currently, the juju-bundle implementation in the upload-bundle action changes directories to the specified path and looks for a bundle.yaml file as seen in here:

import * as core from '@actions/core';
import * as exec from '@actions/exec';

class Bundle {
  async publish(path: string, channel: string) {
    core.exportVariable('CHARMCRAFT_AUTH', core.getInput('credentials'));
    process.chdir(path);
    await exec.exec('juju-bundle', [
      'publish',
      '--destructive-mode',
      '--serial',
      '--release',
      channel,
    ]);
  }
}

export { Bundle };

This unnecessarily enforces bundle names which creates unnecessary rigidity to how bundle repos have to be structured. Not only do the bundles have to be named bundle.yaml, but they also will have to be in separate directories. This makes little sense when a path to a specific bundle can be given straight to juju-bundle using --bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant