Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload-charm should catch and raise on empty credentials #42

Open
ca-scribner opened this issue Jun 3, 2022 · 1 comment
Open

upload-charm should catch and raise on empty credentials #42

ca-scribner opened this issue Jun 3, 2022 · 1 comment
Assignees
Labels
Type: Bug Something isn't working

Comments

@ca-scribner
Copy link
Contributor

The Kubeflow team had CI using this action recently fail when executed from a fork. We believe this is because the fork did not define the credentials secret, thus meaning the credentials argument passed to upload-charm was an empty string.

Assuming this is the correct failure mode, upload-charm should catch and fail with an obvious error when it is passed blank or obviously incorrect credentials. Calling the action with an empty credential is an especially easy error to make in github actions, as actions will silently use an uninstantiated variable rather than raise an error.

@ca-scribner ca-scribner added the Type: Bug Something isn't working label Jun 3, 2022
@simskij
Copy link
Member

simskij commented Jun 7, 2022

Makes sense! Feel free to go for it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants