Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integrate instead of add_relation or relate #861

Open
DnPlas opened this issue Apr 4, 2024 · 2 comments
Open

Use integrate instead of add_relation or relate #861

DnPlas opened this issue Apr 4, 2024 · 2 comments
Labels
bug Something isn't working Kubeflow 1.8 This issue affects the Charmed Kubeflow 1.8 release Kubeflow 1.9

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Apr 4, 2024

Bug Description

juju relate is the way juju made integrations between two applications, but in 3.x it was deprecated in favour of juju integrate. This has to be reflected in:

  • Docs
  • Integration tests
  • Unit tests (if applicable)

relate and add_relation will be removed soon, and there have been warning messages all around, for example:

WARNING juju.model:model.py:1564 relate is deprecated and will be removed. Use integrate instead.

@DnPlas DnPlas added the bug Something isn't working label Apr 4, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5517.

This message was autogenerated

@DnPlas DnPlas added Kubeflow 1.9 Kubeflow 1.8 This issue affects the Charmed Kubeflow 1.8 release labels Apr 4, 2024
@orfeas-k
Copy link
Contributor

orfeas-k commented Apr 5, 2024

I think what you 're saying is true for add-relation but not relate. From juju 3.4 and on, you don't see that deprecation message anymore. My guess is that they decided to keep it as an alias as it mentions on top of this page, but I 'm not 100% about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Kubeflow 1.8 This issue affects the Charmed Kubeflow 1.8 release Kubeflow 1.9
Projects
None yet
Development

No branches or pull requests

2 participants