Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should charms that use an ingress (kubeflow-dashboard, katib-ui, etc) *require* that ingress to function? #852

Open
ca-scribner opened this issue Mar 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ca-scribner
Copy link
Contributor

Context

All dashboards (and some other charms, such as envoy) provided in Charmed Kubeflow are exposed through the ingress via istio-pilot's ingress relation. Should these charms enforce that an ingress relation is established (and go to Blocked if the ingress is missing)?

There's a good argument for both choices:

  • Arguments for not requiring the ingress:
    • These dashboards do not require an ingress to function (you could browse directly to their ClusterIP without deploying istio)
    • It can be useful to have these charms function without ingresses during testing (that way we don't need istio-pilot in every dashboard test)
  • Arguments for requiring the ingress:
    • the Charmed Kubeflow product itself does require these ingress relations to function properly (otherwise users cannot reach the dashboards). Requiring ingresses would make it easier to spot this misconfiguration

A compromise could be adding a debug or ignore-ingress config value in these charms. By default this config could tell the charm to always require ingresses, but if we set this special flag during testing we could ignore the ingress requirement.

What needs to get done

  1. decide if we should change anything, and if so implement that change in all our dashboards/charms that need an ingress

Definition of Done

See above

@ca-scribner ca-scribner added the enhancement New feature or request label Mar 22, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5477.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant