Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated packages in the prod build #5495

Open
cherifGsoul opened this issue Jun 23, 2020 · 1 comment
Open

Duplicated packages in the prod build #5495

cherifGsoul opened this issue Jun 23, 2020 · 1 comment

Comments

@cherifGsoul
Copy link
Member

The issue was originally reported by @bmomberger-bitovi on slack:

I was tinkering with canjs/canjs on my day off and I noticed that there were a few duplicated packages in 
the prod build. One is two copies of can-validate-validatejs

Castiel-2:canjs bmomberger$ npm ls --prod can-validate-validatejs
can@6.4.0 /Users/bmomberger/Projects/canjs
├─┬ can-define-validate-validatejs@1.1.1
│ └── can-validate-validatejs@0.1.3 
└── can-validate-validatejs@1.0.1 

Also:

The others are from unmaintained feathers packages that we’re using in can-connect-feathers, 
and I’m not sure what to do about those. 

Castiel-2:canjs bmomberger$ npm ls --prod debug
can@6.4.0 /Users/bmomberger/Projects/canjs
└─┬ can-connect-feathers@7.0.0
  ├─┬ @feathersjs/errors@4.5.3
  │ └── debug@4.1.1 
  └─┬ feathers-authentication-popups@0.1.2
    ├── debug@2.6.9 
    └─┬ feathers-errors@2.9.2
      └── debug@3.2.6 
Castiel-2:canjs bmomberger$ npm ls --prod ms
can@6.4.0 /Users/bmomberger/Projects/canjs
└─┬ can-connect-feathers@7.0.0
  ├─┬ @feathersjs/errors@4.5.3
  │ └─┬ debug@4.1.1
  │   └── ms@2.1.2 
  └─┬ feathers-authentication-popups@0.1.2
    ├─┬ debug@2.6.9
    │ └── ms@2.0.0 
    └─┬ feathers-errors@2.9.2
      └─┬ debug@3.2.6
        └── ms@2.1.2  deduped
@cherifGsoul
Copy link
Member Author

cherifGsoul commented Jul 6, 2020

There's a Greenkeeper PR to upgrade can-validate-validatejs can-define-validate-validatejs, I checked it and it doesn't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant