Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can@5.33.2 - version mismatch of can-observable-array with sub-dependency in can-connect #5467

Open
rjgotten opened this issue Jan 29, 2020 · 4 comments

Comments

@rjgotten
Copy link

rjgotten commented Jan 29, 2020

The can@5.33.2 package takes locked version dependencies on can-observable-array@0.8.2 and can-connect@3.2.5. can-connect@3.2.5 in turn takes an open-ended dependency ^0.7.0 for can-observable-array.

But because it is a zero major version, the eligible range is effectively locked to [0.7.0 ... 0.8.0).
NPM cannot consolidate these two versions for deduping and thus gives can-connect its own local copy of can-observable-array@0.7.0

@phillipskevin
Copy link
Collaborator

@rjgotten is there an issue with can-connect having its own version?

@rjgotten
Copy link
Author

rjgotten commented Mar 4, 2020

Browser-bloat, mostly. Which can become larger if dependencies-of-dependencies start coming into play.

@frank-dspeed
Copy link
Contributor

@rjgotten to have less bloat i always use the ecosystem.mjs this reduces the dependency package hell. let all your code depend on the mjs build that also reduces install time simply wget it from unpkg.com i would not use the npm packages.

@rjgotten
Copy link
Author

@frank-dspeed
You know; that is actually not a bad idea. Will have to bring that up with my colleagues and see if we can give that a shot. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants