Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package.json contains an invalid peer dependency #36

Open
ADobin opened this issue Jun 21, 2018 · 1 comment
Open

NPM package.json contains an invalid peer dependency #36

ADobin opened this issue Jun 21, 2018 · 1 comment

Comments

@ADobin
Copy link

ADobin commented Jun 21, 2018

Looking at the package.json in this repo, it contains the following peer dependency

"prop-types": "^15.5.8",

However, when using the 2.0.1 package from NPM I get this in the package.json

"prop-types": "^16.0.0",

I also see the same when I view the package.json through unpkg (in case I had some weird build step ruining all of my packages) here.

This doesn't have any run time impact as far as I can tell but does put a couple warnings into my console about having invalid peer dependencies. Would be nice to clean these up and I was going to submit a PR to fix it but it appears to only be an issue in the published package.

@e110c0
Copy link

e110c0 commented Jul 10, 2018

had the same glitch,

rm -rf node_modules 
npm install

solved it for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants