-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate upstream/downstream libraries - follow ups #4325
Comments
Steps:
|
Commons - [Readme] - Check & Update required Java version (Java 11?)Required version is correct, it was specified in .ci.cambpm but file has been removed during reconciliation. Based on docs: https://docs.camunda.org/manual/7.20/introduction/supported-environments/ supported minimum is Java 11, updated the Readme file. |
Spin - could we use the existing jakarta.jakartaee-bom versioning instead of jakarta.xml.bind-apiPR follow up:
❓Instead of a separate versioning, could we maybe also use the jakarta.jakartaee-bom here? That's already defined and used at several other places so it could be easier for future updates. Platform declares Created a follow up task to have a single version of the lib: |
+1 for keeping the declared versions in sync (e.g. include them in the camunda-bom) |
Freemarket-template-engine uses assertj-core 3.20.2 while platform uses 2.9.1Bumping platform assertj-core up to 3.20.2 (or to latest 3.26.0) fails with:
Downgrading Freemarket-template-engine to 2.9.1 (that is used by platform) build work pushed changes to branch |
Hi @venetrius, I reviewed the linked PRs. All the changes you made make sense to me. 👍 ❌However, I find it hard to understand the exact goals of this issue. I can not understand what needs to be done from the issue description and why, making it impossible to assess if all tasks are completed. It would help to give the issue description more structure. For example, for each task, you can link sources (review feedback, test failures, etc.), describe the problem, and document your decision. ❓ I looked at this list. Does this list include all the TODOs for this issue? The PRs seem to tick all the boxes. ❌You created follow-up issues (#4384 and #4385). When you create new issues, you should ideally pick one of the templates (bug report, task, etc.) and provide the information requested by the template. This would also have helped create a good description for this issue. |
* chore(commons): add typed values to commons-bom * chore(project): update scm tags for spin and commons * chore(commons): Use the platform defined version variable for Logback * docs(commons): Readme - update commons required JRE related to: #4325
Hi @mboskamp, I will reach out offline to discuss the other points. |
This issue tracks multiple enhancements and questions related to dependency management across various modules of the Camunda BPM platform.
related to: #3682
Spin - Unified Jakarta BOM Usage
Context: PR follow up
spin/dataformat-xml-dom-jakarta/pom.xml
❓Instead of a separate versioning, could we maybe also use the jakarta.jakartaee-bom here? That's already defined and used at several other places so it could be easier for future updates.
Outcome:
Platform uses
2.3.3
camunda-spin-dataformat-xml-dom-jakarta uses4.0.2
version ofxml.bind-api
Simply bumping the version to latest or downgrading to2.3.3
causes the build to fail.Created a follow up task to have a single version of the lib: #4383
Spin - update scm tag
Outcome: updated
spin/bom/pom.xml
&spin/pom.xml
Context:
SCM tag points to the old repository which could be an issue in the CI
Spin - remove master branch from file-list
Context:
file-list
is used by internal toolsOutcome: Updated
Commons - update SCM tag
same context and outcome as for Spin
Commons - remove master branch from helpers repo
same context and outcome as for Spin
Commons - Package typed-values with commons-bom
Context: Typed values have been moved under
./commons
but not packaged with thecommons-bom
yet. This can cause confusion during maintenance.Outcome: Packaged typed-values within
commons-bom
Commons - Use the platform defined version variable for Logback
Context: Logback version is hardcoded in
commons/pom.xml
which make maintenance more complicated.Outcome: Update
commons/pom.xml
to use${version.logback}
Commons - Readme - Check & Update required Java version
Outcome: Readme was outdated updated readme to correctly state:
Connect uses wiremock 1.58 while platform uses 2.27
Context: having multiple version of the same library increases maintenance effort.
Outcome: CI fails when bumping
wiremock
. Created follow up task: #4385Connect uses mockito 1.9.5 while platform uses 5.10.0
Context: having multiple version of the same library increases maintenance effort.
Outcome: CI fails when bumping
mockito
. Created follow up task: #4384Freemarket-template-engine uses assertj-core 3.20.2 while platform uses 2.9.1
Context: having multiple version of the same library increases maintenance effort.
Outcome:
Build fails if assertj-core is bumpied up
Downgraded
assertj-core
infreemarker-template-engine/pom.xml
to2.9.1
Breakdown
Pull Requests
The text was updated successfully, but these errors were encountered: