Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The REST API documentation about deployment creation should be integrated #4312

Open
1 task
alessandrocavalli opened this issue May 1, 2024 · 0 comments
Open
1 task
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.22.0

Comments

@alessandrocavalli
Copy link

Acceptance Criteria (Required on creation)

In the deployment/create REST API, the documentation states:

  <@lib.property
        name = "deploy-changed-only"
        type = "boolean"
        defaultValue = 'false'
        desc = "A flag indicating whether the process engine should perform duplicate checking on a per-resource basis.
                If set to true, only those resources that have actually changed are deployed.
                Checks are made against resources included previous deployments of the same name and only against the latest versions of those resources.
                If set to true, the option enable-duplicate-filtering is overridden and set to true." />

    <@lib.property
        name = "enable-duplicate-filtering"
        type = "boolean"
        defaultValue = 'false'
        desc = "A flag indicating whether the process engine should perform duplicate checking for the deployment or not.
                This allows you to check if a deployment with the same name and the same resouces already exists and
                if true, not create a new deployment but instead return the existing deployment. The default value is false." />

but since the deployment-source is also used to check if the deployment is new or not, it would be nice to modify it adding "and source" after the words "of the same name"

  <@lib.property
        name = "deploy-changed-only"
        type = "boolean"
        defaultValue = 'false'
        desc = "A flag indicating whether the process engine should perform duplicate checking on a per-resource basis.
                If set to true, only those resources that have actually changed are deployed.
                Checks are made against resources included previous deployments of the same name and source and only against the latest versions of those resources.
                If set to true, the option enable-duplicate-filtering is overridden and set to true." />

    <@lib.property
        name = "enable-duplicate-filtering"
        type = "boolean"
        defaultValue = 'false'
        desc = "A flag indicating whether the process engine should perform duplicate checking for the deployment or not.
                This allows you to check if a deployment with the same name and source and the same resouces already exists and
                if true, not create a new deployment but instead return the existing deployment. The default value is false." />

Hints

Links

engine-rest/engine-rest-openapi/src/main/templates/models/org/camunda/bpm/engine/rest/dto/MultiFormDeploymentDto.ftl

Breakdown

Pull Requests

No tasks being tracked yet.

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@alessandrocavalli alessandrocavalli added the type:task Issues that are a change to the project that is neither a feature nor a bug fix. label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.22.0
Projects
None yet
Development

No branches or pull requests

2 participants