Issue 677 Add Variables property to FailJobCommand #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Zelldon
reviewed
May 23, 2024
There was a problem hiding this comment.
Hey @brandon-mork thank you very much for your contribution and efforts to work on this 🚀 The PR looks great in general :)
Please update your commit message to align with our contribution guide https://github.com/camunda/zeebe/blob/main/CONTRIBUTING.md#commit-message-guidelines
For example use for your doc comment docs: fix typo or for the additional functionality feat: add variables to fail command
|
Fixed my commit messages! Thank you for your work creating and maintaining this project -- it has been very helpful for my team and me! |
Zelldon
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #677