Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deployment): Added support for form deployment response #649

Merged
merged 3 commits into from
May 23, 2024
Merged

fix(deployment): Added support for form deployment response #649

merged 3 commits into from
May 23, 2024

Conversation

sindremb
Copy link
Contributor

@sindremb sindremb commented Feb 6, 2024

This PR adds support for form deployment response and closes #648

I've tried to keep the implementation as similar as possible to the existing deployment response types. Let me know if there is anything else I should include in this PR.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

Zelldon
Zelldon requested changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

It would be great if we could also extend the test cases we have related to deployments. As example see this https://github.com/camunda-community-hub/zeebe-client-csharp/blob/main/Client.UnitTests/DeploymentTest.cs#L262

Maybe you can add one with forms as well, so we validate everything is set correctly.

Client/Api/Responses/IFormMetadata.cs Show resolved Hide resolved
@sindremb
Copy link
Contributor Author

Thank you very much for your contribution!

It would be great if we could also extend the test cases we have related to deployments. As example see this https://github.com/camunda-community-hub/zeebe-client-csharp/blob/main/Client.UnitTests/DeploymentTest.cs#L262

Maybe you can add one with forms as well, so we validate everything is set correctly.

Sure thing! I'll try to get it done soon.

@sindremb
Copy link
Contributor Author

@Zelldon I've extended the tests for multiple deploy resources to also cover form deployments. Let me know if that is sufficient or not.

@Zelldon Zelldon self-requested a review March 1, 2024 13:07
Zelldon
Zelldon approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so sorry for the delay! I was quite busy with other projects. Thank you again for your contribution! Looks great.

I guess would be great to have an IT test for this as well (can be easily done in our IT subproject). But I can do this myself, later :)

@Zelldon
Copy link
Collaborator

Zelldon commented May 23, 2024

Looks like CI is not running. I will check this first.

@Zelldon Zelldon merged commit bdc563d into camunda-community-hub:main May 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zelldon Zelldon Zelldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploying camunda form fails due to unsupported response type
3 participants
@sindremb @CLAassistant @Zelldon