Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying camunda form fails due to unsupported response type #648

Closed
sindremb opened this issue Feb 6, 2024 · 0 comments · Fixed by #649
Closed

Deploying camunda form fails due to unsupported response type #648

sindremb opened this issue Feb 6, 2024 · 0 comments · Fixed by #649
Assignees
Labels
bug Something isn't working

Comments

@sindremb
Copy link
Contributor

sindremb commented Feb 6, 2024

Describe the bug
If you add a .form file as a resource to a deploy command, the deploy itself is performed, but the client throws an exception due to an unsupported response type from the command.

To Reproduce
Steps to reproduce the behavior:

  1. Create any camunda form (.form file) using for instance camunda desktop modeller
  2. Send a deploy command referencing your form as a resource
var deployResponse = await client
              .NewDeployCommand()
              .AddResourceFile("path-to-my-sample.form")
              .Send();
  1. Observe thrown exception in processing Send()
    Unhandled Exception: System.NotImplementedException: Got deployment response for unexpected type: Form

Expected behavior
Client library should fully support deploying form resources, especially now that Camunda (since 8.4) supports using linked forms in .bpmn files instead of just embedded forms.

Enviroment (please complete the following information):

  • OS: Any
  • Version: Similar issue found when testing with versions v2.2-v2.5

Additional context
I'll create a PR that adds support for the form deployment response based on the other existing deployment response implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants