Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue as member variable breaks my program #135

Open
benjibst opened this issue Sep 7, 2022 · 2 comments
Open

Queue as member variable breaks my program #135

benjibst opened this issue Sep 7, 2022 · 2 comments

Comments

@benjibst
Copy link

benjibst commented Sep 7, 2022

While trying to make my Video to ascii program multithreaded, by adding this queue i created a bug that i just cant fix and i figured out what is causing it just now.
Whenever i have a queue as a member variable in my class an error occurs, and if i comment the member variable declaration out it doesnt happen anymore.
Also you can criticize my code overall if you want, im learning

Here is a video of me reproducing this:
https://drive.google.com/file/d/11Y6_ug_H8E413T8e7YkKXet7-9SUaeCH/view?usp=sharing

Pls help me fixing this bug, here is the code on github:
https://github.com/BetterRage/Movie2Ascii.git

To build it you need ffmpeg, SDL, and spdlog

@cameron314
Copy link
Owner

If simply adding the unused queue member to your class causes this bug, as seen in the video, then there's almost certainly undefined behaviour elsewhere in your program, unrelated to the queue itself, that just happens to present itself when the memory layout changes due to the inclusion of the queue.

@benjibst
Copy link
Author

benjibst commented Sep 9, 2022

Thanks for the answer, i will try to fix it.
My temporary fix was to just store the queue somewhere else but thats not a really good solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants