Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podspec issue #16

Merged
merged 2 commits into from Aug 11, 2014
Merged

podspec issue #16

merged 2 commits into from Aug 11, 2014

Conversation

akiroom
Copy link
Contributor

@akiroom akiroom commented Aug 11, 2014

Hi. Thank you for your fantastic library.
This pull request fixes some problem.
I hope it will be nice for you.
FIXED: #14

@Mazyod
Copy link
Collaborator

Mazyod commented Aug 11, 2014

Arigato gozaimasu, kansha shimasu :)

Yeah, I think @callumboddy can merge this one 👍

@akiroom
Copy link
Contributor Author

akiroom commented Aug 11, 2014

Thank you for your gentle message! I'm very happy.
I'm looking forward to reviewing by callumboddy.
Have a nice day!

@callumboddy
Copy link
Owner

Yep good spot akiroom, ill merge this in, thanks

callumboddy added a commit that referenced this pull request Aug 11, 2014
@callumboddy callumboddy merged commit 8507998 into callumboddy:master Aug 11, 2014
@akiroom
Copy link
Contributor Author

akiroom commented Aug 11, 2014

Thank you for your very fast response!

1.0.0 tag still points the old commit (10c3c4b), so I can't use your great latest.
Could you put 1.0.0 tag to the latest commit(8507998)?

@callumboddy
Copy link
Owner

Ill update this asap, although I will be quite busy until this evening (GMT) thanks

@akiroom
Copy link
Contributor Author

akiroom commented Aug 11, 2014

I've got it. Thank you so much:smiley:

@Dids
Copy link

Dids commented Jan 18, 2015

The tag still needs to be updated. You can do this quickly from the command line by browsing to the project directory, then running: git tag -f -a 1.0.0 -m '' && git push --tags --force

That will effectively recreate the tag using the current commit and push the tag to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CBZSplashView.podspec source
4 participants