Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes callback executing before scrolling has finished #55

Open
joxerTMD opened this issue May 2, 2017 · 1 comment · May be fixed by #56
Open

Sometimes callback executing before scrolling has finished #55

joxerTMD opened this issue May 2, 2017 · 1 comment · May be fixed by #56

Comments

@joxerTMD
Copy link

joxerTMD commented May 2, 2017 •
edited

Hello! I've found a little bug with callback mechanism.
In my app i'm relying on window.addEventListener('scroll', /** my super code **/ ).
I also relying on jumper's callback option, and sometimes callback executes before the last scroll event happens.
See: https://jsfiddle.net/mxqfjLge/ (I hope it will reproduce on your screen resolution)
image
i have prepared PR #56 to fix this
@joxerTMD joxerTMD linked a pull request May 2, 2017 that will close this issue
Open
@joxerTMD
Copy link
Author

joxerTMD commented Aug 10, 2017 •
edited

Sry, is anybody here? This bug is significant to me. I'm of cause already using my own patched version of the library, but it would be great to use the offical one. If my solution makes no sense or incorrect it would be nice to know any other workaround :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix issue with callback executing before scrolling has actually finished joxerTMD/jump.js
1 participant
@joxerTMD