Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log package: support logging to file #245

Open
caitong93 opened this issue Oct 26, 2018 · 7 comments
Open

Log package: support logging to file #245

caitong93 opened this issue Oct 26, 2018 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@caitong93
Copy link
Contributor

/kind feature

@caicloud-bot caicloud-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 26, 2018
@kdada
Copy link
Collaborator

kdada commented Oct 26, 2018

Please implement it and file a PR.

@gaocegege
Copy link
Contributor

gaocegege commented Dec 18, 2018

Hi, I am a student from Shanghai Jiao Tong University and will be a Caiclouder in the next year. I am interested in the project :-) I am glad to implement the feature as my first contribution when I am free in the next month.

While, I have a question about our logger package. There are many libraries about loggers then I am not sure why we implemented the std logger on our own. Is there any thing I missed about it? I'd appreciate it if you could resolve my doubts.

@kdada
Copy link
Collaborator

kdada commented Dec 19, 2018

Actually the biggest problem is there are so many log libraries. So we implement a common log interface (glog-like) to constraint our codes. Then you can replace the implementation of logger with any other packages which you like.

In the other hand, Nirvana should have its own log packages for common usages. e.g. std, file.

@kdada
Copy link
Collaborator

kdada commented Dec 19, 2018

@gaocegege go ahead. You can write your design doc in this issue.

@volgariver6
Copy link

@gaocegege hello,what is the status of this issue?

@kdada
Copy link
Collaborator

kdada commented Oct 8, 2019

@lauber00 There is no implementation of file logger now. If you could implement it, we'll very appreciate it.

@gaocegege
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants