Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine should not call method from cyclone server #1137

Open
cd1989 opened this issue Jun 13, 2019 · 1 comment
Open

Engine should not call method from cyclone server #1137

cd1989 opened this issue Jun 13, 2019 · 1 comment
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cd1989
Copy link
Contributor

cd1989 commented Jun 13, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

Workflow Engine is lower level component of Cyclone, it should not be aware of Cyclone Server logic. So call method of Cyclone server is not allowed.

So this is not allowed:

https://github.com/caicloud/cyclone/blob/master/pkg/workflow/controller/handlers/workflowtrigger/cron_job.go#L19

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

@caicloud-bot caicloud-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 13, 2019
@supereagle
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants