Change http status code on interceptor

[nykolaslima]

I have a simple controller:

@Post("/user")
public void add(User user) {
 userDao.add(user);
 result.use(status()).created();
}

But there is a HibernateTransactionInterceptor that commits the database transaction at the end of the request. But if there is some error commiting the request, I want to change the response status:

@AroundCall
    public void intercept(SimpleInterceptorStack stack) {
        try {
            stack.next();
        } catch(Exception e) {
            logger.error("Unexpected exception", e);
            result.use(status()).internalServerError();
        }
    }

But the response was already commited and then the returned http code is the created(201) that was configured in the controller.

Is there any way to fix it? @Turini

[nykolaslima]

I got it fixed here by overriding GsonSerializer class to avoid flushQuietly(writer); method to be called. This call commits the HttpServletResponse before it should be committed, because interceptors could still make changes in it.

@csokol @Turini let's change those classes to do not flush the HttpServletResponse's OutputStream?

[Turini]

@nykolaslima that sounds reasonable to me... i'm just not sure if it'll break any expected
behaviour. Can we just remove the flushQuietly call and everything will work just fine?

[nykolaslima]

From the tests I've made everything works fine. I believe that flush is already called somewhere, maybe it should be called from application server and not from application code. @Turini

[csokol]

@nykolaslima, I guess overriding GsonSerializer only fixes the case in which you're using Results#json, right? Does it solve the issue with Result#status?

[nykolaslima]

I guess it solves the Result#status problem too. Because the response isn't forced to flush in the GsonSerializer.

[csokol]

Huum, strange, why is Result#status related with json serialization?

On Mon, Dec 7, 2015 at 12:01 PM Nykolas Laurentino de Lima <
notifications@github.com> wrote:

I guess it solves the Result#status problem too. Because the response
isn't forced to flush in the GsonSerializer.

—
Reply to this email directly or view it on GitHub
#1035 (comment).

[nykolaslima]

Sorry @csokol, you are right.
Just using #Result.status works fine. The problem is in flush.