Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting initial version when --pattern is supplied #57

Closed
wants to merge 2 commits into from

Conversation

jsok
Copy link
Contributor

@jsok jsok commented Jan 14, 2022

Fixes #56

`DescribeTag` has inconsistent behaviour if a pattern is supplied.
If no pattern is supplied, not finding any tags is not an error, whereas
if a pattern is supplied, it is an error to not find any tags.

Remove the ambiguity by returning an explicit error describing what
occurred and let `main` decide how to handle it.
Surface the initial version as a flag, making it customizable too.
@jsok
Copy link
Contributor Author

jsok commented Jul 12, 2022

Feel free to re-open if you think #56 is worth solving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial version does not work if pattern is supplied
1 participant