Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If log is empty forcePatchIncrement should not increment the version number #129

Open
matteosilv opened this issue Sep 8, 2023 · 1 comment

Comments

@matteosilv
Copy link

if forcePatchIncrement || isPatch(log) {
	return current.IncPatch()
}

means that even if log is empty (no commits since last tag) and forcePatchIncrement is true a new patch version is bumped. But if I am on top a tag means that I am already on a release. IMHO forcePatchIncrement should only work if there are commits (without fix: feat: or ! identifier) on top of the last tag.

@caarlos0
Copy link
Owner

hmmm yeah, I can see the argument for both cases, since force implies that it would always create the patch...

maybe we could have another flag for create a patch if there are >0 commits? no idea how to name it though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants