Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images count issue #19

Open
ijameelkhan opened this issue Nov 7, 2017 · 5 comments
Open

Images count issue #19

ijameelkhan opened this issue Nov 7, 2017 · 5 comments

Comments

@ijameelkhan
Copy link

Review the following code , in the picker class , gives me 3 images if i select 6 in the block as you increasing the index twice in the loop

This is my code where i am having an issue
id callback = ^(NSArray * images){

};

// Prepare result
NSMutableArray * result = _mediaInfos;
if (!_returnMediaInfoMode)
{
result = [NSMutableArray arrayWithCapacity:_mediaInfos.count];
for (NSUInteger index = 0; index < _mediaInfos.count; index++)
{
[result addObject:((NBUMediaInfo *)_mediaInfos[index++]).editedImage];
}
}

@rivera-ernesto
Copy link
Contributor

Right. Could make a PR?

@ijameelkhan
Copy link
Author

it skips half of the selected images if i select 4 i get only 2 in callback and so on

@ijameelkhan
Copy link
Author

i forked the repo and fixed this problem but seems likely some issue in 1.60
'MotionOrientation_PTEz/MotionOrientation.h' file not found

@rivera-ernesto
Copy link
Contributor

Was your branch created from the latest master?

@ijameelkhan
Copy link
Author

Yes and also please try using it in Xcode 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants