Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded files, defaults, gitignore and zip archive, the big picture #33

Open
naholyr opened this issue Nov 8, 2017 · 0 comments
Open

Comments

@naholyr
Copy link
Member

naholyr commented Nov 8, 2017

We have several issues around excluded files today:

  • If one wants to cast assets, it's currently impossible. Maybe we should remove our defaults and only rely on .gitignore?
  • When one downloads the zip archive, he may expect to have a working copy (assets, node_modules)? But you definitely don't want them to pollute UI? Should we ignore exclusions for zip file (but what if there is a private file amongst them?)?

So I take all that and came to the following conclusions I'd like to discuss:

  • Zip file should contain all files, except gitignore'd ones, properly serving the purpose of grabbing a full copy of the project
  • UI should only show un-gitignored TEXT files, any binary file should not be visible
    • however we should still send the WHOLE tree to socket, and filter front-side so we can make it an option for users who want to cherry-pick a single binary file
    • we should even watch and notify changes on binary files for the day we want to show a binary file has been modified (default behavior would become a binary file does not show up unless it's been recently modified)
  • So basically: no more default exclusions server-side, and a mime-based exclusion client-side
@naholyr naholyr changed the title Remove default excluded files and only rely on .gitignore Excluded files, defaults, gitignore and zip archive, the big picture Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant