Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/crypto to v0.22.0 and Minimum Go Version to 1.18 to Address Security Vulnerabilities #1529

Open
buckedunicorn opened this issue May 2, 2024 · 0 comments

Comments

@buckedunicorn
Copy link

Please update the golang.org/x/crypto package to version 0.22.0 and raise the minimum Go version to 1.18.

These changes are needed to address several high and moderate severity security vulnerabilities, specifically CVE-2021-43565, CVE-2022-27191, CVE-2023-48795, and CVE-2022-29526, which were present in the previously used version of the crypto package.

Updating ensures that the DiscordGo library remains secure and up-to-date with the latest security patches and features.

The Go version in CI workflows needs updating to support versions from 1.18 through 1.22, maintaining compatibility with current Go releases.

A minimum version of Go >= 1.18.2 is required to fully address all vulnerabilities listed.

Vulnerabilities covered:

Validation Steps Proposed:

  • go mod tidy
  • diff <(gofmt -d .) <(echo -n)
  • go vet -x ./...
  • golint -set_exit_status ./...
  • go test -v -race ./...

Originally Proposed PR: #1528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant