Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validity checks between user and base device configurations #627

Open
qdot opened this issue Apr 21, 2024 · 0 comments
Open

Implement validity checks between user and base device configurations #627

qdot opened this issue Apr 21, 2024 · 0 comments
Assignees
Labels
Features New things to add to the project Library - Server Tasks/Bugs pertaining to the server portion of the library

Comments

@qdot
Copy link
Member

qdot commented Apr 21, 2024

With the new config system, every time a user device connects, it copies info out of the base config file to the user config and uses that definition from then on. However, if for some reason we screw up the base config, the user config will now override that info (i.e. step ranges might be wrong). We should check the validity of user configs on the finish() method of DeviceConfigManagerBuilder and make sure the loaded definitions are correct, and exclude them (and possibly fail finish()) if they aren't.

I rarely see this situation happening, but I'm pretty sure people will be mucking around with the user config file by hand even if I do build a GUI, so I'd like checks to be through.

@qdot qdot added Library - Server Tasks/Bugs pertaining to the server portion of the library Features New things to add to the project labels Apr 21, 2024
@qdot qdot self-assigned this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Features New things to add to the project Library - Server Tasks/Bugs pertaining to the server portion of the library
Projects
None yet
Development

No branches or pull requests

1 participant