You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The early Satisfyer devices don't return any useful information on the manufacturer characteristic, so whilst we match them based on the advertised information, we can't actually work out which device is connected.
Expected behavior/Actual behavior
The Satisfyer Curvy2 should appear as a dual vibe, but in fact it only appears as a single.
Additional context
The "hacky" solution here would probably be to fall back to the device name at this point, but ideally the advertised information would be passed into the intialialiser, so the matched manufacturer data could be used.
The text was updated successfully, but these errors were encountered:
This issue can also be reproduced with the Satisfyer Mono Flex.
It has 2 motors, but control only allows for Vibrate/All Motors, which sometimes includes the second motor and sometimes won't when changing the value.
No, not yet. My original idea for a fix was going to be to fall back to requesting the device name, but since we now know that that's a no go on CoreBluetooth that's going to cause more problems than it solves.
I think it could be solved by passing the whole advertisement struct into the identifier method, but that's quite a large change.
This change passes the ProtocolCommunicationSpecifier down into
ProtocolIdentifier::identify(), which affects all protocols, but
means that the identify() method can access the same data that
was used to decide that this was a suitable protocol implementation
in the first place.
Fixesbuttplugio#547
Describe the bug
The early Satisfyer devices don't return any useful information on the manufacturer characteristic, so whilst we match them based on the advertised information, we can't actually work out which device is connected.
Expected behavior/Actual behavior
The Satisfyer Curvy2 should appear as a dual vibe, but in fact it only appears as a single.
Additional context
The "hacky" solution here would probably be to fall back to the device name at this point, but ideally the advertised information would be passed into the intialialiser, so the matched manufacturer data could be used.
The text was updated successfully, but these errors were encountered: