Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more JsonParser tests #512

Open
qdot opened this issue Oct 12, 2018 · 1 comment
Open

Add more JsonParser tests #512

qdot opened this issue Oct 12, 2018 · 1 comment
Assignees
@qdot
Labels
core Anything relating to core, including parsers, messaging, logging testing Test/QA related issues

Comments

@qdot
Copy link
Member

qdot commented Oct 12, 2018

  • Need a test for schema mismatched system messages
  • Need to check for null on return on ButtplugMessageToJObject and Serialize
  • Need to either do schema validation or check for null array, not both (redundant)
@qdot qdot added testing Test/QA related issues core Anything relating to core, including parsers, messaging, logging labels Oct 12, 2018
@qdot qdot self-assigned this Oct 12, 2018
qdot added a commit that referenced this issue Oct 12, 2018
@qdot
fix: Fix parser comments and exceptions
f3a745f 
- Throw exceptions when no message types are available
- Check for null returns from ButtplugMessageToJObject
- Add more comments

Affects #512 but doesn't fix it 'cause this still needs more tests.
qdot added a commit that referenced this issue Oct 12, 2018
@qdot
fix: Fix parser comments and exceptions
37192bb 
- Throw exceptions when no message types are available
- Check for null returns from ButtplugMessageToJObject
- Add more comments

Affects #512 but doesn't fix it 'cause this still needs more tests.
qdot added a commit that referenced this issue Oct 13, 2018
@qdot
fix: Fix parser comments and exceptions
6643ef3 
- Throw exceptions when no message types are available
- Check for null returns from ButtplugMessageToJObject
- Add more comments

Affects #512 but doesn't fix it 'cause this still needs more tests.
@qdot
Copy link
Member Author

qdot commented Dec 27, 2022

Could probably use more tests here even though we're client only now. Also yanked the schema to reduce dependencies, so it's important that the parser works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qdot qdot

Labels
core Anything relating to core, including parsers, messaging, logging testing Test/QA related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qdot