-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTP QR Code Scanner (camera) #310
Comments
Yes, there is no QR scanner in the app. The workaround is to use a generic QR code scanner and copy the link generated by scanning the code to Buttercup. |
Apple removed OTP->App scanning capabilities in iOS 15. It worked just fine in earlier versions of iOS. I'm still frustrated by their decision. I've been trying to avoid integrating a camera component because:
All that being said, I don't think there's another way. I'd accept a PR for this. |
@perry-mitchell You may want to check this: |
@perry-mitchell Here's my approach: I can implement a QR scanner with a common website using some camera lib available for JavaScript. Then I'll create a webview in react native to point URL of the camera website, apple by default use safari as web render for any application, so it will ask for camera permission each time the website ask for camera, for android is the same behavior. Then I can create a communication thread from website (with JavaScript) to the react native webview and pass the QR code data. The only disadvantage is that internet connection is required for view the camera site. Let me know about your opinion to start working on this feature. Reference: Communications between webview |
Isn't it possible to open a HTML file containing the code for camera connection locally in a webview? That way no internet connection would be needed? |
@julianpoemp Probably write vanilla JavaScript will solve this issue but it'll take longer because I have to embed all camera and QR code on a single HTMl file. |
I think the self contained approach is the only viable way forward. Too much of a security concern to host it externally, and Buttercup should work "offline" in a locked down network. Ideally we'd build this HTML file - maybe we make this a separate library on the Buttercup namespace, and then install it with npm to utilise it within the app? |
@QuinsZouls would you have any interest in working on this at all? |
@perry-mitchell Here's my current report:
If nothing works as well, I have a plan b: |
What do you think about this: https://github.com/mebjas/html5-qrcode The demo works for me on android and ios. Perhaps this fixes the android asset issue: https://stackoverflow.com/a/74966760/6303600 |
@julianpoemp |
It could be that I am just missing it but I cant find the qr code scanner anywhere in the app... given that the desktop app doesn't have an interface or mechanism for doing this the mobile app doing it is pretty important. am I just missing something?
The text was updated successfully, but these errors were encountered: