Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split examples into separate folders #22

Open
bookercodes opened this issue Jun 25, 2017 · 3 comments
Open

Split examples into separate folders #22

bookercodes opened this issue Jun 25, 2017 · 3 comments

Comments

@bookercodes
Copy link
Contributor

At the moment, example has a lot of "boilerplate" to accommodate multiple use-case demos, which can make the code harder than necessary to follow and understand.

Rather than having one example folder, let's create an examples folder with a sub-folder for each demo, e.g.:

+ examples
 | basic-form-validation
 | asynchronous-form-validation
 | password-form-validation

I propose we use react-scripts to remove the need for webpack.config.js and other files not related to Revalidation. We should also use minimal styling in this folder to keep the examples focused on how Revalidation works 👍.

We could consider building a nice-looking demo for the website but keeping it separate from examples?

@busypeoples
Copy link
Owner

Yes, makes sense. We can add a styled example with Rebass or SC.

@bookercodes
Copy link
Contributor Author

So, I am thinking these would be some good examples:

  • Simple validation
  • Asynchronous validation (with progress indicator)
  • Password validation (comparing fields)
  • Complex form (examples of input[type="text"] select, and other form elements)
  • Disable submit button
  • React Bootstrap example (good example of how easily you can add custom styles)
  • Example with validator.js

What do you think? Also, what else can we add?

@busypeoples
Copy link
Owner

Sounds great. Maybe a rebass example?
https://www.webpackbin.com/bins/-KnG58K1TEbUzSmRsmD5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants