Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-based caching for Siesta #289

Open
jordanpwood opened this issue Mar 28, 2019 · 4 comments · May be fixed by #306
Open

File-based caching for Siesta #289

jordanpwood opened this issue Mar 28, 2019 · 4 comments · May be fixed by #306
Projects

Comments

@jordanpwood
Copy link

I find myself needing a file-based cache for Siesta. I see that there is a branch named file-cache in the repo. It's my understanding that this is the beginning of a file caching system for Siesta, correct? Is it a dead end with serious problems, or simply unfinished work? If the latter, what still needs to be done? If it fits the requirements I have for a file cache, I could work on it and make a PR, but I'd like to know more about how you envision it working @pcantrell, and what things need to happen before it is ready to be used. Let me know!

@pcantrell
Copy link
Member

It is very much ready for experiments! It has a couple of subtle issues I wanted to fix before merging, but it is certainly not a dead end. On the run now, but I’ll drop some notes about those “subtle issues” when I have a little more time.

@pcantrell
Copy link
Member

P.S. The GithubBrowser project on that branch has an example of how to configure and use it: https://github.com/bustoutsolutions/siesta/blob/file-cache/Examples/GithubBrowser/Source/API/GithubAPI.swift#L40-L67

@ahknight
Copy link

Any update on this? It is, unfortunately, not a drop-in class for the release version of the framework due to method signature changes (which are beneficial, just breaking).

@tkirby
Copy link

tkirby commented Nov 8, 2019

Is there an updated Filecache.swift that works with latest Siesta version? I tried the one from the file-cache branch but it's giving this error in a few places:

FileCache' does not conform to protocol 'EntityCache'

@pcantrell pcantrell linked a pull request Apr 6, 2020 that will close this issue
@pcantrell pcantrell added this to In progress in 1.6 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
1.6
  
In progress
Development

Successfully merging a pull request may close this issue.

4 participants