Add tvOS support [partially completed]

[pcantrell]

• Add tvOS target
• Prove viability with a test app
• Get specs passing on tvOS
• Add tvOS environment(s) to Travis build matrix
• Ensure it works with:
  • Carthage
  • CocoaPods

(Looks like @djz-code may be working on this on a fork?)

[igostavro]

whoever starts on this, just a tip:

I pulled from git and started my own local pod spec.

Had to make the following changes:

#s.resources = "Source/**/*.xib" <<-- remove xibs

  s.subspec "Core" do |s|
    s.source_files = "Source/**/*.swift" #<<-- only copy swift files as source (WAS pulling xibs)
  end

The xib in the project is an iOS xib that prevents TVOS from compiling. Once I excluded it from the pod everything seemed to compile just fine. Testing now.

[igostavro]

As a followup:

maybe ResourceStatusOverlay.xib (and maybe related code) should be moved into a subspec called ResourceStatusOverlayIOS

[victorcotap]

It would be very beneficial if it could work on watchOs as well. Being able to build one api client for all platforms would be a tremendous improvement
Also splitting UI and Core code might help the process as @igostavro suggested

EDIT: Actually WatchKit includes way of getting data through the iOS app so it's ok if it's dismissed for now. tvOS would be amazing to get tho. Can we split Siesta and SiestaUI ?

[pcantrell]

Actually WatchKit includes way of getting data through the iOS app so it's ok if it's dismissed for now.

That was my understanding, but…

It would be very beneficial if it could work on watchOs as well.

I’m all for it if anyone finds a need for it.

tvOS would be amazing to get tho

I’d welcome a pull request.

Can we split Siesta and SiestaUI ?

Already done. Isolating UIKit code was done by @onekiloparsec for the macOS target, and I already split SiestaUI for SwiftPM support. Siesta & SiestaUI are now two separate subdirectories under Source, separate targets in the Xcode project, separate modules if you build with SwiftPM or Carthage, and separate subspecs if you’re using Cocoapods.

I’m only aware of two spots in the core Siesta module that require platform-specific attention: the type of parsed images, and the name of the low memory notification. Both should be easy to resolve. Search Source/Siesta/ for the two occurrences of #if.

[pcantrell]

Looks like maybe @tritt was working on tvOS support?

[pcantrell]

#187 added a tvOS target. Specs don’t run on tvOS because of Nocilla, but that seems solvable.

I'd like to hear from users about any success / troubles in actual apps before declaring this supported. (See checklist at the top of the issue.)