From 2df3bf4c7ea9a36757a4bf50890daec1c1a14a4a Mon Sep 17 00:00:00 2001 From: Mark Guinn Date: Mon, 2 Mar 2015 21:58:39 +0000 Subject: [PATCH] Quick fix to bug in universal analytics --- code/ShopGoogleAnalytics.php | 2 +- code/ShopGoogleAnalyticsController.php | 5 ++++- templates/GAConversion.ss | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/code/ShopGoogleAnalytics.php b/code/ShopGoogleAnalytics.php index 63f84c8..f50ca35 100644 --- a/code/ShopGoogleAnalytics.php +++ b/code/ShopGoogleAnalytics.php @@ -45,7 +45,7 @@ class ShopGoogleAnalytics extends Object * @return string */ public static function get_property_id() { - if (self::config()->disable_on_dev && !\Director::isLive()){ + if (self::config()->disable_on_dev && !Director::isLive()) { return ''; } diff --git a/code/ShopGoogleAnalyticsController.php b/code/ShopGoogleAnalyticsController.php index 22f7983..c9a2f60 100644 --- a/code/ShopGoogleAnalyticsController.php +++ b/code/ShopGoogleAnalyticsController.php @@ -45,7 +45,10 @@ public function addGASnippet($name, $order = false) { $snippets = $cfg->tracking_code; if (isset($snippets[$type]) && isset($snippets[$type][$name])) { - $js = $this->owner->renderWith($snippets[$type][$name], array('Order' => $order)); + $js = $this->owner->renderWith($snippets[$type][$name], array( + 'Order' => $order, + 'GAWebPropertyID' => $this->GAWebProperyID(), + )); } if (!empty($js)) { diff --git a/templates/GAConversion.ss b/templates/GAConversion.ss index 1997caf..50aca9f 100644 --- a/templates/GAConversion.ss +++ b/templates/GAConversion.ss @@ -4,7 +4,7 @@ ga('require', 'ecommerce'); ga('ecommerce:addTransaction', { 'id': '$JS_val(Reference)', 'affiliation': '$Top.SiteConfig.JS_val(Title)', - 'revenue': '$Total.RAW' + 'revenue': '$Total.RAW', 'shipping': '$GAShippingTotal', 'tax': '$GATaxTotal', });